feat: Update Next.js with pages-router to v8.0.0-beta.4 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig/nextjs-pages-router-v8
branch
from
fd13e20 to
8abfef8
Compare
s1gr1d
commented
Apr 25, 2024
Comment on lines
+97
to
99
| "parent_span_id": "[[ID3]]", | ||
| "span_id": "[[ID4]]", | ||
| "trace_id": "[[ID2]]" |
There was a problem hiding this comment.
Is there some data missing in "trace"?
s1gr1d
commented
Apr 25, 2024
| "timestamp": "[[timestamp]]", | ||
| "transaction": "GET /api/pages-router/test-param-error/1337" | ||
| "transaction": "GET /api/pages-router/test-param-error/[param]" |
s1gr1d
commented
Apr 25, 2024
Comment on lines
-144
to
-148
| "tags": { | ||
| "http.status_code": "200", | ||
| "runtime": "node", | ||
| "transaction": "GET /api/pages-router/test-param-success/[param]" | ||
| }, |
There was a problem hiding this comment.
The tags are not included anymore
There was a problem hiding this comment.
This is fine and intended! The SDK should generally not set tags!
s1gr1d
commented
Apr 25, 2024
| @@ -13,7 +13,7 @@ | |||
| "sample_rate": "1", | |||
| "sampled": "true", | |||
| "trace_id": "[[ID2]]", | |||
| "transaction": "/pages-router/test-route-handlers" | |||
| "transaction": "GET /api/pages-router/test-param-error/[param]" | |||
There was a problem hiding this comment.
This also seems like an improvement
s1gr1d
commented
Apr 25, 2024
| @@ -176,11 +169,11 @@ | |||
| { | |||
| "data": { | |||
| "sentry.op": "browser", | |||
| "sentry.origin": "auto.browser.browser.metrics" | |||
| "sentry.origin": "auto.ui.browser.metrics" | |||
There was a problem hiding this comment.
The origin changed here (also below)
s1gr1d
force-pushed
the
sig/nextjs-pages-router-v8
branch
from
85c4177 to
5024e71
Compare
s1gr1d
commented
Apr 25, 2024
Comment on lines
-109
to
-112
| "hardwareConcurrency": "10", | ||
| "lcp.element": "body > div#__next > p", | ||
| "lcp.size": "[[highNumber]]", | ||
| "routing.instrumentation": "next-pages-router", |
There was a problem hiding this comment.
I think the should still be included 🤔
Or they are not included because there was no lcp event in this case. Other transactions also don't have it
s1gr1d
force-pushed
the
sig/nextjs-pages-router-v8
branch
from
5024e71 to
aaa2e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.